Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f46feab authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

qlcnic: potential NULL dereference in qlcnic_83xx_get_minidump_template() 



If qlcnic_fw_cmd_get_minidump_temp() fails then "fw_dump->tmpl_hdr" is
NULL or possibly freed.  It can lead to an oops later.

Fixes: d01a6d3c ('qlcnic: Add support to enable capability to extend minidump for iSCSI')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 685764b1

drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c

+6 −2
Original line number Diff line number Diff line
@@ -1417,6 +1417,7 @@ void qlcnic_83xx_get_minidump_template(struct qlcnic_adapter *adapter) 
	struct qlcnic_fw_dump *fw_dump = &ahw->fw_dump;

	struct pci_dev *pdev = adapter->pdev;

	bool extended = false;

	int ret;



	prev_version = adapter->fw_version;

	current_version = qlcnic_83xx_get_fw_version(adapter);
@@ -1427,7 +1428,10 @@ void qlcnic_83xx_get_minidump_template(struct qlcnic_adapter *adapter) 
		if (qlcnic_83xx_md_check_extended_dump_capability(adapter))

			extended = !qlcnic_83xx_extend_md_capab(adapter);



		if (!qlcnic_fw_cmd_get_minidump_temp(adapter))

		ret = qlcnic_fw_cmd_get_minidump_temp(adapter);

		if (ret)

			return;



		dev_info(&pdev->dev, "Supports FW dump capability\n");



		/* Once we have minidump template with extended iSCSI dump