Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5f3b7284 authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Tony Lindgren
Browse files

omap: McBSP: Fix potential memory leak in omap_mcbsp_remove 



Function omap_mcbsp_probe allocates struct omap_mcbsp *mcbsp but it is not
freed in omap_mcbsp_remove. Fix this, remove unneeded structure cleanups
and clk_disable calls since they are not needed here.

This is not problem currently but becomes if the mcbsp driver is ever
modularized.

Signed-off-by: default avatarJarkko Nikula <jhnikula@gmail.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent b1cc4c55

arch/arm/plat-omap/mcbsp.c

+1 −7
Original line number Diff line number Diff line
@@ -1836,17 +1836,11 @@ static int __devexit omap_mcbsp_remove(struct platform_device *pdev) 


		omap34xx_device_exit(mcbsp);



		clk_disable(mcbsp->fclk);

		clk_disable(mcbsp->iclk);

		clk_put(mcbsp->fclk);

		clk_put(mcbsp->iclk);



		iounmap(mcbsp->io_base);



		mcbsp->fclk = NULL;

		mcbsp->iclk = NULL;

		mcbsp->free = 0;

		mcbsp->dev = NULL;

		kfree(mcbsp);

	}



	return 0;