Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5be1df66 authored by Himangi Saraogi's avatar Himangi Saraogi Committed by Michal Marek
Browse files

Coccinelle: Script to replace if and BUG with BUG_ON 



This script detects cases where BUG() follows an if condition on an
expression and replaces the if condition and BUG() with a BUG_ON having
the conditional expression of the if statement as argument.

Signed-off-by: default avatarHimangi Saraogi <himangi774@gmail.com>
Acked-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarMichal Marek <mmarek@suse.cz>
parent e52320c3

scripts/coccinelle/misc/bugon.cocci

0 → 100644
+62 −0
Original line number Diff line number Diff line 
/// Use BUG_ON instead of a if condition followed by BUG.

///

//# This makes an effort to find cases where BUG() follows an if

//# condition on an expression and replaces the if condition and BUG()

//# with a BUG_ON having the conditional expression of the if statement

//# as argument.

//

// Confidence: High

// Copyright: (C) 2014 Himangi Saraogi.  GPLv2.

// Comments:

// Options: --no-includes, --include-headers



virtual patch

virtual context

virtual org

virtual report



//----------------------------------------------------------

//  For context mode

//----------------------------------------------------------



@depends on context@

expression e;

@@



*if (e) BUG();



//----------------------------------------------------------

//  For patch mode

//----------------------------------------------------------



@depends on patch@

expression e;

@@



-if (e) BUG();

+BUG_ON(e);



//----------------------------------------------------------

//  For org and report mode

//----------------------------------------------------------



@r@

expression e;

position p;

@@



 if (e) BUG@p ();



@script:python depends on org@

p << r.p;

@@



coccilib.org.print_todo(p[0], "WARNING use BUG_ON")



@script:python depends on report@

p << r.p;

@@



msg="WARNING: Use BUG_ON"

coccilib.report.print_report(p[0], msg)