Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a258d03 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Linus Torvalds
Browse files

fbdev: fb_create_modedb() non-static `int first = 1;' 



Looking at the code flow, `int first' in fb_create_modedb() should be static.

[adaplas]
Better for 'int first' to be moved outside the loop.

[akpm@linux-foundation.org: kill stray semicolon]
Signed-off-by: default avatarGeert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: default avatarAntonino Daplas <adaplas@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 42b558d5

drivers/video/fbmon.c

+1 −3
Original line number Diff line number Diff line
@@ -591,7 +591,7 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize) 
{

	struct fb_videomode *mode, *m;

	unsigned char *block;

	int num = 0, i;

	int num = 0, i, first = 1;



	mode = kzalloc(50 * sizeof(struct fb_videomode), GFP_KERNEL);

	if (mode == NULL)
@@ -608,8 +608,6 @@ static struct fb_videomode *fb_create_modedb(unsigned char *edid, int *dbsize) 
	DPRINTK("   Detailed Timings\n");

	block = edid + DETAILED_TIMING_DESCRIPTIONS_START;

	for (i = 0; i < 4; i++, block+= DETAILED_TIMING_DESCRIPTION_SIZE) {

	        int first = 1;



		if (!(block[0] == 0x00 && block[1] == 0x00)) {

			get_detailed_timing(block, &mode[num]);

			if (first) {