Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 586b9a4d authored by Christian König's avatar Christian König Committed by Alex Deucher
Browse files

drm/amd/pp: fix "Delete the wrapper layer of smu_allocate/free_memory" 



For amdgpu_bo_create_kernel to work the handle must be NULL initialized,
otherwise we only try to pin and map the BO.

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarRex Zhu <rezhu@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent bb03c9c4

drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c

+1 −1
Original line number Diff line number Diff line
@@ -327,10 +327,10 @@ static int rv_start_smu(struct pp_hwmgr *hwmgr) 


static int rv_smu_init(struct pp_hwmgr *hwmgr)

{

	struct amdgpu_bo *handle = NULL;

	struct rv_smumgr *priv;

	uint64_t mc_addr;

	void *kaddr = NULL;

	struct amdgpu_bo *handle;

	int r;



	priv = kzalloc(sizeof(struct rv_smumgr), GFP_KERNEL);

drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c

+1 −1
Original line number Diff line number Diff line
@@ -377,11 +377,11 @@ static int vega10_verify_smc_interface(struct pp_hwmgr *hwmgr) 


static int vega10_smu_init(struct pp_hwmgr *hwmgr)

{

	struct amdgpu_bo *handle = NULL;

	struct vega10_smumgr *priv;

	uint64_t mc_addr;

	void *kaddr = NULL;

	unsigned long tools_size;

	struct amdgpu_bo *handle;

	int ret;

	struct cgs_firmware_info info = {0};