Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57370aed authored by Sylwester Nawrocki's avatar Sylwester Nawrocki Committed by Kukjin Kim
Browse files

ARM: S3C24XX: Free the backlight gpio requested in Mini2440 board code 



The backlight gpio must not be left requested in the board
code, otherwise s3c24xx_led driver can't successfully claim it.
So request the backlight gpio, configure it to proper state and
gpio_free right away.

This change is required for converting the s3c24xx_led driver
to the gpiolib API.

Signed-off-by: default avatarSylwester Nawrocki <sylvester.nawrocki@gmail.com>
Acked-by: default avatarJuergen Beisert <jbe@pengutronix.de>
Signed-off-by: default avatarKukjin Kim <kgene.kim@samsung.com>
parent bd0a521e

arch/arm/mach-s3c24xx/mach-mini2440.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -634,8 +634,8 @@ static void __init mini2440_init(void) 
	s3c_gpio_cfgpin(S3C2410_GPC(0), S3C2410_GPC0_LEND);

	s3c_gpio_cfgpin(S3C2410_GPC(0), S3C2410_GPC0_LEND);





	/* Turn the backlight early on */

	/* Turn the backlight early on */

	WARN_ON(gpio_request(S3C2410_GPG(4), "backlight"));

	WARN_ON(gpio_request_one(S3C2410_GPG(4), GPIOF_OUT_INIT_HIGH, NULL));

	gpio_direction_output(S3C2410_GPG(4), 1);

	gpio_free(S3C2410_GPG(4));





	/* remove pullup on optional PWM backlight -- unused on 3.5 and 7"s */

	/* remove pullup on optional PWM backlight -- unused on 3.5 and 7"s */

	s3c_gpio_setpull(S3C2410_GPB(1), S3C_GPIO_PULL_UP);

	s3c_gpio_setpull(S3C2410_GPB(1), S3C_GPIO_PULL_UP);