Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 55de2923 authored by Shirish S's avatar Shirish S Committed by Harry Wentland
Browse files

drm/atomic: Add new reverse iterator over all plane state (V2) 



Add reverse iterator for_each_oldnew_plane_in_state_reverse to
compliment the for_each_oldnew_plane_in_state way or reading plane
states.

The plane states are required to be read in reverse order for
amd drivers, cause the z order convention followed in linux is
opposite to how the planes are supposed to be presented to DC
engine, which is in common to both windows and linux.

V2: fix compile time errors due to -Werror flag.

Signed-off-by: default avatarShirish S <shirish.s@amd.com>
Signed-off-by: default avatarPratik Vishwakarma <Pratik.Vishwakarma@amd.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarHarry Wentland <harry.wentland@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/1520392203-6885-1-git-send-email-shirish.s@amd.com
parent 100bc0d9

include/drm/drm_atomic.h

+22 −0
Original line number Original line Diff line number Diff line
@@ -753,6 +753,28 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); 
			      (old_plane_state) = (__state)->planes[__i].old_state,\

			      (old_plane_state) = (__state)->planes[__i].old_state,\

			      (new_plane_state) = (__state)->planes[__i].new_state, 1))

			      (new_plane_state) = (__state)->planes[__i].new_state, 1))





/**

 * for_each_oldnew_plane_in_state_reverse - iterate over all planes in an atomic

 * update in reverse order

 * @__state: &struct drm_atomic_state pointer

 * @plane: &struct drm_plane iteration cursor

 * @old_plane_state: &struct drm_plane_state iteration cursor for the old state

 * @new_plane_state: &struct drm_plane_state iteration cursor for the new state

 * @__i: int iteration cursor, for macro-internal use

 *

 * This iterates over all planes in an atomic update in reverse order,

 * tracking both old and  new state. This is useful in places where the

 * state delta needs to be considered, for example in atomic check functions.

 */

#define for_each_oldnew_plane_in_state_reverse(__state, plane, old_plane_state, new_plane_state, __i) \

	for ((__i) = ((__state)->dev->mode_config.num_total_plane - 1);	\

	     (__i) >= 0;						\

	     (__i)--)							\

		for_each_if ((__state)->planes[__i].ptr &&		\

			     ((plane) = (__state)->planes[__i].ptr,	\

			      (old_plane_state) = (__state)->planes[__i].old_state,\

			      (new_plane_state) = (__state)->planes[__i].new_state, 1))



/**

/**

 * for_each_old_plane_in_state - iterate over all planes in an atomic update

 * for_each_old_plane_in_state - iterate over all planes in an atomic update

 * @__state: &struct drm_atomic_state pointer

 * @__state: &struct drm_atomic_state pointer