Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 55af7796 authored by Mitsuo Hayasaka's avatar Mitsuo Hayasaka Committed by Ingo Molnar
Browse files

x86: Panic on detection of stack overflow 



Currently, messages are just output on the detection of stack
overflow, which is not sufficient for systems that need a
high reliability. This is because in general the overflow may
corrupt data, and the additional corruption may occur due to
reading them unless systems stop.

This patch adds the sysctl parameter
kernel.panic_on_stackoverflow and causes a panic when detecting
the overflows of kernel, IRQ and exception stacks except user
stack according to the parameter. It is disabled by default.

Signed-off-by: default avatarMitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>
Cc: yrl.pp-manager.tt@hitachi.com
Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Link: http://lkml.kernel.org/r/20111129060836.11076.12323.stgit@ltc219.sdl.hitachi.co.jp


Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 37fe6a42

Documentation/sysctl/kernel.txt

+14 −0
Original line number Diff line number Diff line
@@ -49,6 +49,7 @@ show up in /proc/sys/kernel: 
- panic

- panic_on_oops

- panic_on_unrecovered_nmi

- panic_on_stackoverflow

- pid_max

- powersave-nap               [ PPC only ]

- printk
@@ -393,6 +394,19 @@ Controls the kernel's behaviour when an oops or BUG is encountered. 


==============================================================



panic_on_stackoverflow:



Controls the kernel's behavior when detecting the overflows of

kernel, IRQ and exception stacks except a user stack.

This file shows up if CONFIG_DEBUG_STACKOVERFLOW is enabled.



0: try to continue operation.



1: panic immediately.



==============================================================





pid_max:



PID allocation wrap value.  When the kernel's next PID value

arch/x86/kernel/irq_32.c

+2 −0
Original line number Diff line number Diff line
@@ -43,6 +43,8 @@ static void print_stack_overflow(void) 
{

	printk(KERN_WARNING "low stack detected by irq handler\n");

	dump_stack();

	if (sysctl_panic_on_stackoverflow)

		panic("low stack detected by irq handler - check messages\n");

}



#else

arch/x86/kernel/irq_64.c

+5 −0
Original line number Diff line number Diff line
@@ -26,6 +26,8 @@ EXPORT_PER_CPU_SYMBOL(irq_stat); 
DEFINE_PER_CPU(struct pt_regs *, irq_regs);

EXPORT_PER_CPU_SYMBOL(irq_regs);



int sysctl_panic_on_stackoverflow;



/*

 * Probabilistic stack overflow check:

 *
@@ -65,6 +67,9 @@ static inline void stack_overflow_check(struct pt_regs *regs) 
		current->comm, curbase, regs->sp,

		irq_stack_top, irq_stack_bottom,

		estack_top, estack_bottom);



	if (sysctl_panic_on_stackoverflow)

		panic("low stack detected by irq handler - check messages\n");

#endif

}

include/linux/kernel.h

+1 −0
Original line number Diff line number Diff line
@@ -341,6 +341,7 @@ extern int panic_timeout; 
extern int panic_on_oops;

extern int panic_on_unrecovered_nmi;

extern int panic_on_io_nmi;

extern int sysctl_panic_on_stackoverflow;

extern const char *print_tainted(void);

extern void add_taint(unsigned flag);

extern int test_taint(unsigned flag);

kernel/sysctl.c

+9 −0
Original line number Diff line number Diff line
@@ -803,6 +803,15 @@ static struct ctl_table kern_table[] = { 
		.mode		= 0644,

		.proc_handler	= proc_dointvec,

	},

#ifdef CONFIG_DEBUG_STACKOVERFLOW

	{

		.procname	= "panic_on_stackoverflow",

		.data		= &sysctl_panic_on_stackoverflow,

		.maxlen		= sizeof(int),

		.mode		= 0644,

		.proc_handler	= proc_dointvec,

	},

#endif

	{

		.procname	= "bootloader_type",

		.data		= &bootloader_type,