Commit 549e8292 authored Jan 15, 2013 by Takashi Iwai

ALSA: hda/ca0132 - Fix possible NULL dereference



Spotted by smatch,
  sound/pci/hda/patch_ca0132.c:1950 dspxfr_image() error: potential
  null dereference 'dma_engine'.  (kzalloc returns null)
  sound/pci/hda/patch_ca0132.c:1950 dspxfr_image() error: we
  previously assumed 'dma_engine' could be null (see line 1857)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 425a7880

sound/pci/hda/patch_ca0132.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -2416,15 +2416,13 @@ static int dspxfr_image(struct hda_codec *codec,
		return -EINVAL;

		dma_engine = kzalloc(sizeof(*dma_engine), GFP_KERNEL);
		if (!dma_engine) {
		status = -ENOMEM;
		goto exit;
		}
		if (!dma_engine)
		return -ENOMEM;

		dma_engine->dmab = kzalloc(sizeof(*dma_engine->dmab), GFP_KERNEL);
		if (!dma_engine->dmab) {
		status = -ENOMEM;
		goto exit;
		kfree(dma_engine);
		return -ENOMEM;
		}

		dma_engine->codec = codec;