Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 53fb84a0 authored Feb 04, 2008 by Samuel Tardieu Committed by David Woodhouse Feb 07, 2008

[MTD] [DOC200x] eccbuf is statically defined and always evaluate to true



Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
Acked-by: Joern Engel <joern@logfs.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>

parent d5476689

drivers/mtd/devices/doc2000.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -632,7 +632,7 @@ static int doc_read(struct mtd_info *mtd, loff_t from, size_t len,
		len = ((from \| 0x1ff) + 1) - from;

		/* The ECC will not be calculated correctly if less than 512 is read */
		if (len != 0x200 && eccbuf)
		if (len != 0x200)
		printk(KERN_WARNING
		"ECC needs a full sector read (adr: %lx size %lx)\n",
		(long) from, (long) len);
		@@ -896,7 +896,7 @@ static int doc_write(struct mtd_info *mtd, loff_t to, size_t len,
		/* Let the caller know we completed it */
		*retlen += len;

		if (eccbuf) {
		{
		unsigned char x[8];
		size_t dummy;
		int ret;

drivers/mtd/devices/doc2001plus.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -748,7 +748,7 @@ static int doc_write(struct mtd_info *mtd, loff_t to, size_t len,
		WriteDOC(DoC_GetDataOffset(mtd, &fto), docptr, Mplus_FlashCmd);

		/* On interleaved devices the flags for 2nd half 512 are before data */
		if (eccbuf && before)
		if (before)
		fto -= 2;

		/* issue the Serial Data In command to initial the Page Program process */