Commit 516cf1be authored May 01, 2012 by Jim Cromie Committed by Greg Kroah-Hartman May 01, 2012

dynamic_debug: use printk(KERN_WARNING..) in stub function



drivers/infiniband/ulp/srp/ib_srp.c #defines pr_fmt() PFX fmt, but PFX
is not #defined until after <linux/*> headers are included.

This results in a bad expansion of the pr_warn() in the stub function.

2084c2084
<   printk("<4>" PFX "dyndbg supported only in " "CONFIG_DYNAMIC_DEBUG builds\n")

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3ec5652a

include/linux/dynamic_debug.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -109,7 +109,8 @@ static inline int ddebug_dyndbg_module_param_cb(char param, char val,
		const char *modname)
		{
		if (strstr(param, "dyndbg")) {
		pr_warn("dyndbg supported only in "
		/* avoid pr_warn(), which wants pr_fmt() fully defined */
		printk(KERN_WARNING "dyndbg param is supported only in "
		"CONFIG_DYNAMIC_DEBUG builds\n");
		return 0; /* allow and ignore */
		}