Commit 50756ebe authored Oct 14, 2016 by Dan Carpenter Committed by David S. Miller Oct 15, 2016

stmmac: fix an error code in stmmac_ptp_register()



PTR_ERR(NULL) is success.  We have to preserve the error code earlier.

Fixes: 7086605a ("stmmac: fix error check when init ptp")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 93966b71

drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -185,8 +185,10 @@ int stmmac_ptp_register(struct stmmac_priv *priv)
		priv->ptp_clock = ptp_clock_register(&priv->ptp_clock_ops,
		priv->device);
		if (IS_ERR(priv->ptp_clock)) {
		int ret = PTR_ERR(priv->ptp_clock);

		priv->ptp_clock = NULL;
		return PTR_ERR(priv->ptp_clock);
		return ret;
		}

		spin_lock_init(&priv->ptp_lock);