Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 48968f8d authored by Robert Baldyga's avatar Robert Baldyga Committed by Greg Kroah-Hartman
Browse files

usb: gadget: f_fs: add missing spinlock and mutex unlock 



This patch adds missing spin_unlock and mutex_unlock calls in
error handling code.

Signed-off-by: default avatarRobert Baldyga <r.baldyga@samsung.com>
Acked-by: default avatarMichal Nazarewicz <mina86@mina86.com>
Acked-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dad4babe

drivers/usb/gadget/f_fs.c

+6 −2
Original line number Diff line number Diff line
@@ -802,7 +802,7 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) 
		if (io_data->aio) {

			req = usb_ep_alloc_request(ep->ep, GFP_KERNEL);

			if (unlikely(!req))

				goto error;

				goto error_lock;



			req->buf      = data;

			req->length   = io_data->len;
@@ -817,7 +817,7 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) 
			ret = usb_ep_queue(ep->ep, req, GFP_ATOMIC);

			if (unlikely(ret)) {

				usb_ep_free_request(ep->ep, req);

				goto error;

				goto error_lock;

			}

			ret = -EIOCBQUEUED;
@@ -865,6 +865,10 @@ static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data *io_data) 


	mutex_unlock(&epfile->mutex);

	return ret;



error_lock:

	spin_unlock_irq(&epfile->ffs->eps_lock);

	mutex_unlock(&epfile->mutex);

error:

	kfree(data);

	return ret;