Commit 47b7360c authored Sep 08, 2018 by Thomas Gleixner

x86/apic/vector: Make error return value negative



activate_managed() returns EINVAL instead of -EINVAL in case of
error. While this is unlikely to happen, the positive return value would
cause further malfunction at the call site.

Fixes: 2db1f959 ("x86/vector: Handle managed interrupts proper")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org

parent 9fe6299d

arch/x86/kernel/apic/vector.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -413,7 +413,7 @@ static int activate_managed(struct irq_data *irqd)
		if (WARN_ON_ONCE(cpumask_empty(vector_searchmask))) {
		/* Something in the core code broke! Survive gracefully */
		pr_err("Managed startup for irq %u, but no CPU\n", irqd->irq);
		return EINVAL;
		return -EINVAL;
		}

		ret = assign_managed_vector(irqd, vector_searchmask);