Commit 4773a47d authored Dec 18, 2009 by Uwe Kleine-König Committed by David S. Miller Dec 18, 2009

can/at91: don't check platform_get_irq's return value against zero



platform_get_irq returns -ENXIO on failure, so !irq was probably
always true.  Better use (int)irq <= 0.  Note that a return value of
zero is still handled as error even though this could mean irq0.

This is a followup to 305b3228 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 01a1e7ec

drivers/net/can/at91_can.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -1037,7 +1037,7 @@ static int __init at91_can_probe(struct platform_device *pdev)

	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
	irq = platform_get_irq(pdev, 0);		irq = platform_get_irq(pdev, 0);
	if (!res \|\| !irq) {		if (!res \|\| irq <= 0) {
	err = -ENODEV;		err = -ENODEV;
	goto exit_put;		goto exit_put;
	}		}