Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 465fc643 authored by Emil Tantilov's avatar Emil Tantilov Committed by Jeff Kirsher
Browse files

ixgbevf: fix spoofed packets with random MAC 



If ixgbevf is loaded while the corresponding PF interface is down
and the driver assigns a random MAC address, that address can be
overwritten with the value of hw->mac.perm_addr, which would be 0 at
that point.

To avoid this case we init hw->mac.perm_addr to the randomly generated
address and do not set it unless we receive ACK from ixgbe.

Reported-by: default avatarJohn Greene <jogreene@redhat.com>
Signed-off-by: default avatarEmil Tantilov <emil.s.tantilov@intel.com>
Tested-by: default avatarKrishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 91a76baa

drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -2664,6 +2664,7 @@ static int ixgbevf_sw_init(struct ixgbevf_adapter *adapter) 
		dev_info(&pdev->dev, "Assigning random MAC address\n");

		dev_info(&pdev->dev, "Assigning random MAC address\n");

		eth_hw_addr_random(netdev);

		eth_hw_addr_random(netdev);

		ether_addr_copy(hw->mac.addr, netdev->dev_addr);

		ether_addr_copy(hw->mac.addr, netdev->dev_addr);

		ether_addr_copy(hw->mac.perm_addr, netdev->dev_addr);

	}

	}





	/* Enable dynamic interrupt throttling rates */

	/* Enable dynamic interrupt throttling rates */

drivers/net/ethernet/intel/ixgbevf/vf.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -117,7 +117,9 @@ static s32 ixgbevf_reset_hw_vf(struct ixgbe_hw *hw) 
	    msgbuf[0] != (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_NACK))

	    msgbuf[0] != (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_NACK))

		return IXGBE_ERR_INVALID_MAC_ADDR;

		return IXGBE_ERR_INVALID_MAC_ADDR;





	if (msgbuf[0] == (IXGBE_VF_RESET | IXGBE_VT_MSGTYPE_ACK))

		ether_addr_copy(hw->mac.perm_addr, addr);

		ether_addr_copy(hw->mac.perm_addr, addr);



	hw->mac.mc_filter_type = msgbuf[IXGBE_VF_MC_TYPE_WORD];

	hw->mac.mc_filter_type = msgbuf[IXGBE_VF_MC_TYPE_WORD];





	return 0;

	return 0;