Commit 44a6f0df authored Jan 09, 2014 by Patrick McHardy Committed by Pablo Neira Ayuso Jan 09, 2014

netfilter: nf_tables: prohibit deletion of a table with existing sets



We currently leak the set memory when deleting a table that still has
sets in it. Return EBUSY when attempting to delete a table with sets.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent 7047f9d0

net/netfilter/nf_tables_api.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -467,7 +467,7 @@ static int nf_tables_deltable(struct sock nlsk, struct sk_buff skb,
	if (IS_ERR(table))		if (IS_ERR(table))
	return PTR_ERR(table);		return PTR_ERR(table);

	if (table->use)		if (!list_empty(&table->chains) \|\| !list_empty(&table->sets))
	return -EBUSY;		return -EBUSY;

	list_del(&table->list);		list_del(&table->list);