Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 413708bb authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

enic: fix an endian bug in enic_probe() 



"num_vfs" is a u32 but we only use the high 16 bits and the low 16bits
are left as zero.  That isn't a problem for little endian systems but it
will break on big endian ones.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 73f98eab

drivers/net/ethernet/cisco/enic/enic.h

+1 −1
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ struct enic { 
	u32 rx_coalesce_usecs;

	u32 tx_coalesce_usecs;

#ifdef CONFIG_PCI_IOV

	u32 num_vfs;

	u16 num_vfs;

#endif

	struct enic_port_profile *pp;

drivers/net/ethernet/cisco/enic/enic_main.c

+1 −1
Original line number Diff line number Diff line
@@ -2370,7 +2370,7 @@ static int __devinit enic_probe(struct pci_dev *pdev, 
	pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_SRIOV);

	if (pos) {

		pci_read_config_word(pdev, pos + PCI_SRIOV_TOTAL_VF,

			(u16 *)&enic->num_vfs);

			&enic->num_vfs);

		if (enic->num_vfs) {

			err = pci_enable_sriov(pdev, enic->num_vfs);

			if (err) {