Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3dd9fe8c authored by KAMEZAWA Hiroyuki's avatar KAMEZAWA Hiroyuki Committed by Linus Torvalds
Browse files

memory unplug: isolate_lru_page fix 



release_pages() in mm/swap.c changes page_count() to be 0 without removing
PageLRU flag...

This means isolate_lru_page() can see a page, PageLRU() &&
page_count(page)==0..  This is BUG.  (get_page() will be called against
count=0 page.)

Signed-off-by: default avatarKAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: default avatarChristoph Lameter <clameter@sgi.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent dc386d4d

mm/migrate.c

+1 −2
Original line number Diff line number Diff line
@@ -49,9 +49,8 @@ int isolate_lru_page(struct page *page, struct list_head *pagelist) 
		struct zone *zone = page_zone(page);



		spin_lock_irq(&zone->lru_lock);

		if (PageLRU(page)) {

		if (PageLRU(page) && get_page_unless_zero(page)) {

			ret = 0;

			get_page(page);

			ClearPageLRU(page);

			if (PageActive(page))

				del_page_from_active_list(zone, page);