Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3cf164c8 authored by Or Gerlitz's avatar Or Gerlitz Committed by Roland Dreier
Browse files

mlx4_core: Remove annoying debug messages from SR-IOV flow 



These debug prints left behind by commits c82e9aa0 ("mlx4_core:
resource tracking for HCA resources used by guests"), 54679e14
("mlx4: Implement QP paravirtualization and maintain phys_pkey_cache
for smp_snoop") and 993c401e ("mlx4_core: Add IB port-state
machine and port mgmt event propagation") make it pretty hard to
actually use the mlx4_core debug messages when running in SRIOV/IB
mode -- for example, the module load sequence of a device with one VF
yielded 631 debug prints, with 408 of them being from this set.  Let's
just remove them.

Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent bef83ed9

drivers/net/ethernet/mellanox/mlx4/eq.c

+0 −6
Original line number Original line Diff line number Diff line
@@ -329,9 +329,6 @@ int set_and_calc_slave_port_state(struct mlx4_dev *dev, int slave, 
	ctx = &priv->mfunc.master.slave_state[slave];

	ctx = &priv->mfunc.master.slave_state[slave];

	spin_lock_irqsave(&ctx->lock, flags);

	spin_lock_irqsave(&ctx->lock, flags);





	mlx4_dbg(dev, "%s: slave: %d, current state: %d new event :%d\n",

		 __func__, slave, cur_state, event);



	switch (cur_state) {

	switch (cur_state) {

	case SLAVE_PORT_DOWN:

	case SLAVE_PORT_DOWN:

		if (MLX4_PORT_STATE_DEV_EVENT_PORT_UP == event)

		if (MLX4_PORT_STATE_DEV_EVENT_PORT_UP == event)
@@ -366,9 +363,6 @@ int set_and_calc_slave_port_state(struct mlx4_dev *dev, int slave, 
			goto out;

			goto out;

	}

	}

	ret = mlx4_get_slave_port_state(dev, slave, port);

	ret = mlx4_get_slave_port_state(dev, slave, port);

	mlx4_dbg(dev, "%s: slave: %d, current state: %d new event"

		 " :%d gen_event: %d\n",

		 __func__, slave, cur_state, event, *gen_event);





out:

out:

	spin_unlock_irqrestore(&ctx->lock, flags);

	spin_unlock_irqrestore(&ctx->lock, flags);

drivers/net/ethernet/mellanox/mlx4/resource_tracker.c

+0 −6
Original line number Original line Diff line number Diff line
@@ -330,9 +330,6 @@ static void update_pkey_index(struct mlx4_dev *dev, int slave, 




	new_index = priv->virt2phys_pkey[slave][port - 1][orig_index];

	new_index = priv->virt2phys_pkey[slave][port - 1][orig_index];

	*(u8 *)(inbox->buf + 35) = new_index;

	*(u8 *)(inbox->buf + 35) = new_index;



	mlx4_dbg(dev, "port = %d, orig pkey index = %d, "

		 "new pkey index = %d\n", port, orig_index, new_index);

}

}





static void update_gid(struct mlx4_dev *dev, struct mlx4_cmd_mailbox *inbox,

static void update_gid(struct mlx4_dev *dev, struct mlx4_cmd_mailbox *inbox,
@@ -351,9 +348,6 @@ static void update_gid(struct mlx4_dev *dev, struct mlx4_cmd_mailbox *inbox, 
		if (optpar & MLX4_QP_OPTPAR_ALT_ADDR_PATH)

		if (optpar & MLX4_QP_OPTPAR_ALT_ADDR_PATH)

			qp_ctx->alt_path.mgid_index = slave & 0x7F;

			qp_ctx->alt_path.mgid_index = slave & 0x7F;

	}

	}



	mlx4_dbg(dev, "slave %d, new gid index: 0x%x ",

		slave, qp_ctx->pri_path.mgid_index);

}

}





static int mpt_mask(struct mlx4_dev *dev)

static int mpt_mask(struct mlx4_dev *dev)