Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b74c73f authored by Felipe Balbi's avatar Felipe Balbi Committed by Greg Kroah-Hartman
Browse files

usb: gadget: inode: switch over to memdup_user() 



This patch fixes the following Coccinelle warning:

drivers/usb/gadget/inode.c:442:8-15: WARNING \
	opportunity for memdup_user

Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f3c73649

drivers/usb/gadget/inode.c

+3 −6
Original line number Diff line number Diff line
@@ -439,11 +439,9 @@ ep_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) 
	/* FIXME writebehind for O_NONBLOCK and poll(), qlen = 1 */



	value = -ENOMEM;

	kbuf = kmalloc (len, GFP_KERNEL);

	if (!kbuf)

		goto free1;

	if (copy_from_user (kbuf, buf, len)) {

		value = -EFAULT;

	kbuf = memdup_user(buf, len);

	if (!kbuf) {

		value = PTR_ERR(kbuf);

		goto free1;

	}
@@ -452,7 +450,6 @@ ep_write (struct file *fd, const char __user *buf, size_t len, loff_t *ptr) 
		data->name, len, (int) value);

free1:

	mutex_unlock(&data->lock);

	kfree (kbuf);

	return value;

}