Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 375446df authored by Amitoj Kaur Chawla's avatar Amitoj Kaur Chawla Committed by Jacek Anaszewski
Browse files

leds: 88pm860x: Use devm_led_classdev_register 



Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.

Also, remove platform_set_drvdata in probe function and the remove
function, pm860x_led_remove as it is now has nothing to do.

The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
  .probe = probefn,
  .remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
  ...
  e =
- led_classdev_register
+ devm_led_classdev_register
  (...);
   ...
?- led_classdev_unregister(...);
  ...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>

Signed-off-by: default avatarAmitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
parent e0442d7d

drivers/leds/leds-88pm860x.c

+1 −11
Original line number Diff line number Diff line
@@ -195,7 +195,6 @@ static int pm860x_led_probe(struct platform_device *pdev) 
		sprintf(data->name, "led1-blue");

		break;

	}

	platform_set_drvdata(pdev, data);

	data->chip = chip;

	data->i2c = (chip->id == CHIP_PM8606) ? chip->client : chip->companion;

	data->port = pdev->id;
@@ -208,7 +207,7 @@ static int pm860x_led_probe(struct platform_device *pdev) 
	data->cdev.brightness_set_blocking = pm860x_led_set;

	mutex_init(&data->lock);



	ret = led_classdev_register(chip->dev, &data->cdev);

	ret = devm_led_classdev_register(chip->dev, &data->cdev);

	if (ret < 0) {

		dev_err(&pdev->dev, "Failed to register LED: %d\n", ret);

		return ret;
@@ -217,21 +216,12 @@ static int pm860x_led_probe(struct platform_device *pdev) 
	return 0;

}



static int pm860x_led_remove(struct platform_device *pdev)

{

	struct pm860x_led *data = platform_get_drvdata(pdev);



	led_classdev_unregister(&data->cdev);



	return 0;

}



static struct platform_driver pm860x_led_driver = {

	.driver	= {

		.name	= "88pm860x-led",

	},

	.probe	= pm860x_led_probe,

	.remove	= pm860x_led_remove,

};



module_platform_driver(pm860x_led_driver);