Commit 3672558c authored Apr 19, 2006 by Hua Zhong Committed by David S. Miller Apr 19, 2006

[NET]: sockfd_lookup_light() returns random error for -EBADFD



This applies to 2.6.17-rc2.

There is a missing initialization of err in sockfd_lookup_light() that
could return random error for an invalid file handle.

Signed-off-by: Hua Zhong <hzhong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 52824b6b

net/socket.c

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -490,6 +490,7 @@ static struct socket sockfd_lookup_light(int fd, int err, int *fput_needed)
	struct file *file;		struct file *file;
	struct socket *sock;		struct socket *sock;

			*err = -EBADF;
	file = fget_light(fd, fput_needed);		file = fget_light(fd, fput_needed);
	if (file) {		if (file) {
	sock = sock_from_file(file, err);		sock = sock_from_file(file, err);