Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36471012 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

tcp: must free metrics at net dismantle 



We currently leak all tcp metrics at struct net dismantle time.

tcp_net_metrics_exit() frees the hash table, we must first
iterate it to free all metrics.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f5addb91

net/ipv4/tcp_metrics.c

+12 −0
Original line number Original line Diff line number Diff line
@@ -731,6 +731,18 @@ static int __net_init tcp_net_metrics_init(struct net *net) 




static void __net_exit tcp_net_metrics_exit(struct net *net)

static void __net_exit tcp_net_metrics_exit(struct net *net)

{

{

	unsigned int i;



	for (i = 0; i < (1U << net->ipv4.tcp_metrics_hash_log) ; i++) {

		struct tcp_metrics_block *tm, *next;



		tm = rcu_dereference_protected(net->ipv4.tcp_metrics_hash[i].chain, 1);

		while (tm) {

			next = rcu_dereference_protected(tm->tcpm_next, 1);

			kfree(tm);

			tm = next;

		}

	}

	kfree(net->ipv4.tcp_metrics_hash);

	kfree(net->ipv4.tcp_metrics_hash);

}

}