Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 357d5615 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

serial: samsung: only use earlycon for console 



A configuration that enables earlycon but not the core console
code causes a link error:

  drivers/built-in.o: In function `setup_earlycon':
  drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'

That error can be triggered by the newly added samsung earlycon support,
which is missing a 'select' statement.

As suggested by Peter Hurley, solves the problem by moving the
'select SERIAL_EARLYCON' statement to the samsung console driver
option, as it is done by all other console drivers.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Fixes: b94ba032 ("serial: samsung: Add support for early console")
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent abab381f

drivers/tty/serial/Kconfig

+1 −1
Original line number Diff line number Diff line
@@ -241,7 +241,6 @@ config SERIAL_SAMSUNG 
	tristate "Samsung SoC serial support"

	depends on PLAT_SAMSUNG || ARCH_EXYNOS

	select SERIAL_CORE

	select SERIAL_EARLYCON

	help

	  Support for the on-chip UARTs on the Samsung S3C24XX series CPUs,

	  providing /dev/ttySAC0, 1 and 2 (note, some machines may not
@@ -277,6 +276,7 @@ config SERIAL_SAMSUNG_CONSOLE 
	bool "Support for console on Samsung SoC serial port"

	depends on SERIAL_SAMSUNG=y

	select SERIAL_CORE_CONSOLE

	select SERIAL_EARLYCON

	help

	  Allow selection of the S3C24XX on-board serial ports for use as

	  an virtual console.