Commit 34ff1bf4 authored Aug 18, 2017 by Colin Ian King Committed by Greg Kroah-Hartman Aug 20, 2017

staging/rts5208: fix incorrect shift to extract upper nybble

The mask of sns_key_info1 suggests the upper nybble is being extracted
however the following shift of 8 bits is too large and always results in
0. Fix this by shifting only by 4 bits to correctly get the upper nybble.

Detected by CoverityScan, CID#142891 ("Operands don't affect result")

Fixes: fa590c22 ("staging: rts5208: add support for rts5208 and rts5288")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6feb5c82

drivers/staging/rts5208/rtsx_scsi.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -414,7 +414,7 @@ void set_sense_data(struct rtsx_chip *chip, unsigned int lun, u8 err_code,
	sense->ascq = ascq;		sense->ascq = ascq;
	if (sns_key_info0 != 0) {		if (sns_key_info0 != 0) {
	sense->sns_key_info[0] = SKSV \| sns_key_info0;		sense->sns_key_info[0] = SKSV \| sns_key_info0;
	sense->sns_key_info[1] = (sns_key_info1 & 0xf0) >> 8;		sense->sns_key_info[1] = (sns_key_info1 & 0xf0) >> 4;
	sense->sns_key_info[2] = sns_key_info1 & 0x0f;		sense->sns_key_info[2] = sns_key_info1 & 0x0f;
	}		}
	}		}