Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32856eea authored by Alexandre Belloni's avatar Alexandre Belloni Committed by Felipe Balbi
Browse files

usb: gadget: udc: atmel: remove memory leak 



Commit bbe097f0 ("usb: gadget: udc: atmel: fix endpoint name")
introduced a memory leak when unbinding the driver. The endpoint names
would not be freed. Solve that by including the name as a string in struct
usba_ep so it is freed when the endpoint is.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 8ae584d1

drivers/usb/gadget/udc/atmel_usba_udc.c

+2 −1
Original line number Diff line number Diff line
@@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev, 
			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);

			goto err;

		}

		ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index);

		sprintf(ep->name, "ep%d", ep->index);

		ep->ep.name = ep->name;



		ep->ep_regs = udc->regs + USBA_EPT_BASE(i);

		ep->dma_regs = udc->regs + USBA_DMA_BASE(i);

drivers/usb/gadget/udc/atmel_usba_udc.h

+1 −0
Original line number Diff line number Diff line
@@ -280,6 +280,7 @@ struct usba_ep { 
	void __iomem				*ep_regs;

	void __iomem				*dma_regs;

	void __iomem				*fifo;

	char					name[8];

	struct usb_ep				ep;

	struct usba_udc				*udc;