Commit 3078fcc1 authored Oct 21, 2005 by David Gibson Committed by Linus Torvalds Oct 21, 2005

[PATCH] ppc64: Fix typo bug in iSeries hash code

This fixes a stupid typo bug in the iSeries hash table code.

When we place a hash PTE in the secondary bucket, instead of setting the
SECONDARY flag bit, as we should, we (redundantly) set the VALID flag.

This was introduced with the patch abolishing bitfields from the hash
table code. Mea culpa, oops. It hasn't been noticed until now because
in practice we don't hit the secondary bucket terribly often.

Signed-off-by: David Gibson <dwg@au1.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 2c86c83b

arch/ppc64/kernel/iSeries_htab.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -66,7 +66,7 @@ static long iSeries_hpte_insert(unsigned long hpte_group, unsigned long va,
	}		}

	if (slot < 0) { /* MSB set means secondary group */		if (slot < 0) { /* MSB set means secondary group */
	vflags \|= HPTE_V_VALID;		vflags \|= HPTE_V_SECONDARY;
	secondary = 1;		secondary = 1;
	slot &= 0x7fffffffffffffff;		slot &= 0x7fffffffffffffff;
	}		}