Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f6adf48 authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso
Browse files

netfilter: nf_tables: free set name in error path 



set->name must be free'd here in case ops->init fails.

Fixes: 38745490 ("netfilter: nf_tables: Allow set names of up to 255 chars")
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 569ccae6

net/netfilter/nf_tables_api.c

+5 −3
Original line number Diff line number Diff line
@@ -3212,18 +3212,20 @@ static int nf_tables_newset(struct net *net, struct sock *nlsk, 


	err = ops->init(set, &desc, nla);

	if (err < 0)

		goto err2;

		goto err3;



	err = nft_trans_set_add(&ctx, NFT_MSG_NEWSET, set);

	if (err < 0)

		goto err3;

		goto err4;



	list_add_tail_rcu(&set->list, &table->sets);

	table->use++;

	return 0;



err3:

err4:

	ops->destroy(set);

err3:

	kfree(set->name);

err2:

	kvfree(set);

err1: