Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d632745 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add PREFER_IS_ENABLED test 



Using #if defined CONFIG_<FOO> || defined CONFIG_<FOO>_MODULE is
more verbose than necessary and IS_ENABLED(CONFIG_<FOO>) is preferred.

So add a test and a message for it.

--fix it to if desired.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent fff7fb0b

scripts/checkpatch.pl

+10 −0
Original line number Diff line number Diff line
@@ -5637,6 +5637,16 @@ sub process { 
			}

		}



# check for #if defined CONFIG_<FOO> || defined CONFIG_<FOO>_MODULE

		if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) {

			my $config = $1;

			if (WARN("PREFER_IS_ENABLED",

				 "Prefer IS_ENABLED(<FOO>) to CONFIG_<FOO> || CONFIG_<FOO>_MODULE\n" . $herecurr) &&

			    $fix) {

				$fixed[$fixlinenr] = "\+#if IS_ENABLED($config)";

			}

		}



# check for case / default statements not preceded by break/fallthrough/switch

		if ($line =~ /^.\s*(?:case\s+(?:$Ident|$Constant)\s*|default):/) {

			my $has_break = 0;