Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2acd09f3 authored by Andy Grover's avatar Andy Grover Committed by Nicholas Bellinger
Browse files

target: Remove unused struct members in se_dev_entry 



Some were incremented, but never used anywhere from what I could tell.

Signed-off-by: default avatarAndy Grover <agrover@redhat.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent b8d26b3b

drivers/target/target_core_device.c

+0 −14
Original line number Diff line number Diff line
@@ -68,7 +68,6 @@ transport_lookup_cmd_lun(struct se_cmd *se_cmd, u32 unpacked_lun) 
		struct se_dev_entry *deve = se_cmd->se_deve;



		deve->total_cmds++;

		deve->total_bytes += se_cmd->data_length;



		if ((se_cmd->data_direction == DMA_TO_DEVICE) &&

		    (deve->lun_flags & TRANSPORT_LUNFLAGS_READ_ONLY)) {
@@ -85,8 +84,6 @@ transport_lookup_cmd_lun(struct se_cmd *se_cmd, u32 unpacked_lun) 
		else if (se_cmd->data_direction == DMA_FROM_DEVICE)

			deve->read_bytes += se_cmd->data_length;



		deve->deve_cmds++;



		se_lun = deve->se_lun;

		se_cmd->se_lun = deve->se_lun;

		se_cmd->pr_res_key = deve->pr_res_key;
@@ -275,17 +272,6 @@ int core_free_device_list_for_node( 
	return 0;

}



void core_dec_lacl_count(struct se_node_acl *se_nacl, struct se_cmd *se_cmd)

{

	struct se_dev_entry *deve;

	unsigned long flags;



	spin_lock_irqsave(&se_nacl->device_list_lock, flags);

	deve = se_nacl->device_list[se_cmd->orig_fe_lun];

	deve->deve_cmds--;

	spin_unlock_irqrestore(&se_nacl->device_list_lock, flags);

}



void core_update_device_list_access(

	u32 mapped_lun,

	u32 lun_access,

drivers/target/target_core_internal.h

+0 −1
Original line number Diff line number Diff line
@@ -8,7 +8,6 @@ extern struct t10_alua_lu_gp *default_lu_gp; 
struct se_dev_entry *core_get_se_deve_from_rtpi(struct se_node_acl *, u16);

int	core_free_device_list_for_node(struct se_node_acl *,

		struct se_portal_group *);

void	core_dec_lacl_count(struct se_node_acl *, struct se_cmd *);

void	core_update_device_list_access(u32, u32, struct se_node_acl *);

int	core_enable_device_list_for_node(struct se_lun *, struct se_lun_acl *,

		u32, u32, struct se_node_acl *, struct se_portal_group *);

drivers/target/target_core_transport.c

+0 −2
Original line number Diff line number Diff line
@@ -2163,8 +2163,6 @@ void transport_generic_free_cmd(struct se_cmd *cmd, int wait_for_tasks) 
		if (wait_for_tasks)

			transport_wait_for_tasks(cmd);



		core_dec_lacl_count(cmd->se_sess->se_node_acl, cmd);



		if (cmd->se_lun)

			transport_lun_remove_cmd(cmd);

include/target/target_core_base.h

+0 −4
Original line number Diff line number Diff line
@@ -572,12 +572,8 @@ struct se_dev_entry { 
	bool			def_pr_registered;

	/* See transport_lunflags_table */

	u32			lun_flags;

	u32			deve_cmds;

	u32			mapped_lun;

	u32			average_bytes;

	u32			last_byte_count;

	u32			total_cmds;

	u32			total_bytes;

	u64			pr_res_key;

	u64			creation_time;

	u32			attach_count;