Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2a39b88b authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm/vblank: Add FIXME comments about moving the vblank ts hooks 



This is going to be a bit too much, but good to have at least a small
note about where this should all head towards.

Acked-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170509140329.24114-3-daniel.vetter@ffwll.ch
parent 3fcdcb27

include/drm/drm_drv.h

+10 −0
Original line number Diff line number Diff line
@@ -276,6 +276,11 @@ struct drm_driver { 
	 *     constant but unknown small number of scanlines wrt. real scanout

	 *     position.

	 *

	 * FIXME:

	 *

	 * Since this is a helper to implement @get_vblank_timestamp, we should

	 * move it to &struct drm_crtc_helper_funcs, like all the other

	 * helper-internal hooks.

	 */

	int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe,

				     unsigned int flags, int *vpos, int *hpos,
@@ -319,6 +324,11 @@ struct drm_driver { 
	 *

	 * True on success, false on failure, which means the core should

	 * fallback to a simple timestamp taken in drm_crtc_handle_vblank().

	 *

	 * FIXME:

	 *

	 * We should move this hook to &struct drm_crtc_funcs like all the other

	 * vblank hooks.

	 */

	bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe,

				     int *max_error,