Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27013661 authored by Tom Herbert's avatar Tom Herbert Committed by David S. Miller
Browse files

fou: Do WARN_ON_ONCE in gue_gro_receive for bad proto callbacks 



Do WARN_ON_ONCE instead of WARN_ON in gue_gro_receive when the offload
callcaks are bad (either don't exist or gro_receive is not specified).

Signed-off-by: default avatarTom Herbert <tom@herbertland.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 58ce31cc

net/ipv4/fou.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -347,7 +347,7 @@ static struct sk_buff **gue_gro_receive(struct sk_buff **head, 
	rcu_read_lock();

	rcu_read_lock();

	offloads = NAPI_GRO_CB(skb)->is_ipv6 ? inet6_offloads : inet_offloads;

	offloads = NAPI_GRO_CB(skb)->is_ipv6 ? inet6_offloads : inet_offloads;

	ops = rcu_dereference(offloads[guehdr->proto_ctype]);

	ops = rcu_dereference(offloads[guehdr->proto_ctype]);

	if (WARN_ON(!ops || !ops->callbacks.gro_receive))

	if (WARN_ON_ONCE(!ops || !ops->callbacks.gro_receive))

		goto out_unlock;

		goto out_unlock;





	pp = ops->callbacks.gro_receive(head, skb);

	pp = ops->callbacks.gro_receive(head, skb);