Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26fd1220 authored by Barry Song's avatar Barry Song Committed by Vinod Koul
Browse files

dmaengine: sirf: fix a typo in moving running dma_desc to active queue 



list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued)
undefined, we either should change it to:
list_move_tail(schan->queued.next, &schan->active)
or
list_move_tail(&sdesc->node, &schan->active)

Signed-off-by: default avatarBarry Song <Baohua.Song@csr.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarVinod Koul <vinod.koul@linux.intel.com>
parent 5997e089

drivers/dma/sirf-dma.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan) 
	sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc,

	sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc,

		node);

		node);

	/* Move the first queued descriptor to active list */

	/* Move the first queued descriptor to active list */

	list_move_tail(&schan->queued, &schan->active);

	list_move_tail(&sdesc->node, &schan->active);





	/* Start the DMA transfer */

	/* Start the DMA transfer */

	writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +

	writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +