Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23f378ad authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Greg Kroah-Hartman
Browse files

drivers: usb-misc: sisusbvga: remove dead code 



The condition modex % 16 cannot be true when modex value is equal to 640
The condition du & 0xff cannot be true when du value is equal to 0x1400

Addresses-Coverity-Id: 101163
Addresses-Coverity-Id: 744373
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3d95521c

drivers/usb/misc/sisusbvga/sisusb.c

+0 −6
Original line number Diff line number Diff line
@@ -1831,16 +1831,10 @@ static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb, 
	SETIREGANDOR(SISCR, 0x09, 0x5f, ((crtcdata[16] & 0x01) << 5));

	SETIREG(SISCR, 0x14, 0x4f);

	du = (modex / 16) * (bpp * 2);	/* offset/pitch */

	if (modex % 16)

		du += bpp;



	SETIREGANDOR(SISSR, 0x0e, 0xf0, ((du >> 8) & 0x0f));

	SETIREG(SISCR, 0x13, (du & 0xff));

	du <<= 5;

	tmp8 = du >> 8;

	if (du & 0xff)

		tmp8++;



	SETIREG(SISSR, 0x10, tmp8);

	SETIREG(SISSR, 0x31, 0x00);	/* VCLK */

	SETIREG(SISSR, 0x2b, 0x1b);