Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 22a07038 authored by Joe Moriarty's avatar Joe Moriarty Committed by Daniel Vetter
Browse files

drm: NULL pointer dereference [null-pointer-deref] (CWE 476) problem 



The Parfait (version 2.1.0) static code analysis tool found the
following NULL pointer derefernce problem.

- drivers/gpu/drm/drm_dp_mst_topology.c
The call to drm_dp_calculate_rad() in function drm_dp_port_setup_pdt()
could result in a NULL pointer being returned to port->mstb due to a
failure to allocate memory for port->mstb.

Signed-off-by: default avatarJoe Moriarty <joe.moriarty@oracle.com>
Reviewed-by: default avatarSteven Sistare <steven.sistare@oracle.com>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180212195144.98323-3-joe.moriarty@oracle.com
parent b88132b4

drivers/gpu/drm/drm_dp_mst_topology.c

+5 −3
Original line number Diff line number Diff line
@@ -1082,10 +1082,12 @@ static bool drm_dp_port_setup_pdt(struct drm_dp_mst_port *port) 
		lct = drm_dp_calculate_rad(port, rad);



		port->mstb = drm_dp_add_mst_branch_device(lct, rad);

		if (port->mstb) {

			port->mstb->mgr = port->mgr;

			port->mstb->port_parent = port;



			send_link = true;

		}

		break;

	}

	return send_link;