Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 21edbb22 authored by Jiri Slaby's avatar Jiri Slaby Committed by David S. Miller
Browse files

NET: netpoll, fix potential NULL ptr dereference 



Stanse found that one error path in netpoll_setup dereferences npinfo
even though it is NULL. Avoid that by adding new label and go to that
instead.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Cc: Daniel Borkmann <danborkmann@googlemail.com>
Cc: David S. Miller <davem@davemloft.net>
Acked-by: default avatar <chavey@google.com>
Acked-by: default avatarMatt Mackall <mpm@selenic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a2f46ee1

net/core/netpoll.c

+2 −2
Original line number Diff line number Diff line
@@ -735,7 +735,7 @@ int netpoll_setup(struct netpoll *np) 
		npinfo = kmalloc(sizeof(*npinfo), GFP_KERNEL);

		if (!npinfo) {

			err = -ENOMEM;

			goto release;

			goto put;

		}



		npinfo->rx_flags = 0;
@@ -845,7 +845,7 @@ int netpoll_setup(struct netpoll *np) 


		kfree(npinfo);

	}



put:

	dev_put(ndev);

	return err;

}