Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1efc80ee authored by Shannon Nelson's avatar Shannon Nelson Committed by Jeff Kirsher
Browse files

i40e: future proof some sizeof calls 



Make sure the sizeof() calls are taking the size of the actual struct
that we care about.  By using the pointer variable, we'll always get
the right struct size, even if the variable type changes sometime in
the future.

Change-ID: Id5858f883cf42447365ea3733080d7714f975bce
Signed-off-by: default avatarShannon Nelson <shannon.nelson@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent d1da3ac0

drivers/net/ethernet/intel/i40e/i40e_common.c

+2 −2
Original line number Diff line number Diff line
@@ -2017,7 +2017,7 @@ i40e_status i40e_aq_add_macvlan(struct i40e_hw *hw, u16 seid, 
	if (count == 0 || !mv_list || !hw)

		return I40E_ERR_PARAM;



	buf_size = count * sizeof(struct i40e_aqc_add_macvlan_element_data);

	buf_size = count * sizeof(*mv_list);



	/* prep the rest of the request */

	i40e_fill_default_direct_cmd_desc(&desc, i40e_aqc_opc_add_macvlan);
@@ -2059,7 +2059,7 @@ i40e_status i40e_aq_remove_macvlan(struct i40e_hw *hw, u16 seid, 
	if (count == 0 || !mv_list || !hw)

		return I40E_ERR_PARAM;



	buf_size = count * sizeof(struct i40e_aqc_remove_macvlan_element_data);

	buf_size = count * sizeof(*mv_list);



	/* prep the rest of the request */

	i40e_fill_default_direct_cmd_desc(&desc, i40e_aqc_opc_remove_macvlan);