Commit 1c430f90 authored Mar 09, 2016 by Amitoj Kaur Chawla Committed by Jacek Anaszewski Mar 14, 2016

leds: max8997: Use devm_led_classdev_register



Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.

Also, remove platform_set_drvdata in probe function and the remove
function, max8997_led_remove as it is now has nothing to do.

The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
  .probe = probefn,
  .remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
  ...
  e =
- led_classdev_register
+ devm_led_classdev_register
  (...);
   ...
?- led_classdev_unregister(...);
  ...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

parent eed16255

drivers/leds/leds-max8997.c

+1 −13

Original line number	Diff line number	Diff line
		@@ -281,30 +281,18 @@ static int max8997_led_probe(struct platform_device *pdev)

		mutex_init(&led->mutex);

		platform_set_drvdata(pdev, led);

		ret = led_classdev_register(&pdev->dev, &led->cdev);
		ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
		if (ret < 0)
		return ret;

		return 0;
		}

		static int max8997_led_remove(struct platform_device *pdev)
		{
		struct max8997_led *led = platform_get_drvdata(pdev);

		led_classdev_unregister(&led->cdev);

		return 0;
		}

		static struct platform_driver max8997_led_driver = {
		.driver = {
		.name = "max8997-led",
		},
		.probe = max8997_led_probe,
		.remove = max8997_led_remove,
		};

		module_platform_driver(max8997_led_driver);