Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1994ff40 authored by Gerd Hoffmann's avatar Gerd Hoffmann Committed by Greg Kroah-Hartman
Browse files

USB: uas: fix locking 



Forgot to unlock in the uas_eh_task_mgmt error paths.

Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0a231403

drivers/usb/storage/uas.c

+2 −0
Original line number Diff line number Diff line
@@ -649,12 +649,14 @@ static int uas_eh_task_mgmt(struct scsi_cmnd *cmnd, 
		shost_printk(KERN_INFO, shost,

			     "%s: %s: submit sense urb failed\n",

			     __func__, fname);

		spin_unlock_irqrestore(&devinfo->lock, flags);

		return FAILED;

	}

	if (uas_submit_task_urb(cmnd, GFP_ATOMIC, function, tag)) {

		shost_printk(KERN_INFO, shost,

			     "%s: %s: submit task mgmt urb failed\n",

			     __func__, fname);

		spin_unlock_irqrestore(&devinfo->lock, flags);

		return FAILED;

	}

	spin_unlock_irqrestore(&devinfo->lock, flags);