Commit 1993519b authored Aug 31, 2017 by Selvin Xavier Committed by Doug Ledford Sep 22, 2017

bnxt_re: Fix memory leak in FRMR path



This patch fixes a memory leak issue when alloc_mr is used.
mr->pages and mr->npages are used only in alloc_mr path. mr->pages
is allocated when alloc_mr is called or in the case of FRMR, while
creating the MR. mr->npages is updated only when the MR created
is used i.e. after invoking map_mr_sg verb, before data transfer.
In the dereg_mr path, if mr->npages is 0, driver ends up not freeing
the memory created.
Removing the npages check from the dereg_mr path for kernel consumers.

Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>

parent 74828b12

drivers/infiniband/hw/bnxt_re/ib_verbs.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3066,7 +3066,7 @@ int bnxt_re_dereg_mr(struct ib_mr *ib_mr)
		return rc;
		}

		if (mr->npages && mr->pages) {
		if (mr->pages) {
		rc = bnxt_qplib_free_fast_reg_page_list(&rdev->qplib_res,
		&mr->qplib_frpl);
		kfree(mr->pages);