Commit 1823342a authored Jul 01, 2018 by Guenter Roeck Committed by Christoph Hellwig Jul 02, 2018

configfs: replace strncpy with memcpy



gcc 8.1.0 complains:

fs/configfs/symlink.c:67:3: warning:
	'strncpy' output truncated before terminating nul copying as many
	bytes from a string as its length
fs/configfs/symlink.c: In function 'configfs_get_link':
fs/configfs/symlink.c:63:13: note: length computed here

Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 707c6235

fs/configfs/symlink.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -64,7 +64,7 @@ static void fill_item_path(struct config_item * item, char * buffer, int length)

	/* back up enough to print this bus id with '/' */		/* back up enough to print this bus id with '/' */
	length -= cur;		length -= cur;
	strncpy(buffer + length,config_item_name(p),cur);		memcpy(buffer + length, config_item_name(p), cur);
	*(buffer + --length) = '/';		*(buffer + --length) = '/';
	}		}
	}		}