Commit 16d9efa4 authored Mar 12, 2015 by Scott Wood Committed by Felipe Balbi Mar 13, 2015

usb: gadget: serial: %pf is only for function pointers



Use %ps for actual addresses, otherwise you'll get bad output
on arches like ppc64 where %pf expects a function descriptor
(which is not what __builtin_return_address returns).

Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Scott Wood <scottwood@freescale.com>
Cc: linux-usb@vger.kernel.org
CC: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent e39af88f

drivers/usb/gadget/function/u_serial.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsigned char ch)
	unsigned long flags;		unsigned long flags;
	int status;		int status;

	pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %pf\n",		pr_vdebug("gs_put_char: (%d,%p) char=0x%x, called from %ps\n",
	port->port_num, tty, ch, __builtin_return_address(0));		port->port_num, tty, ch, __builtin_return_address(0));

	spin_lock_irqsave(&port->port_lock, flags);		spin_lock_irqsave(&port->port_lock, flags);