Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 109b4d00 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: pcl816: only init command support if irq is available 



The async command support requires an irq. Only initialize the subdevice
command support if the request_irq was successfull.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6a8f6de1

drivers/staging/comedi/drivers/pcl816.c

+10 −8
Original line number Diff line number Diff line
@@ -949,18 +949,20 @@ static int pcl816_attach(struct comedi_device *dev, struct comedi_devconfig *it) 
	if (board->n_aichan > 0) {

		s->type = COMEDI_SUBD_AI;

		devpriv->sub_ai = s;

		dev->read_subdev = s;

		s->subdev_flags = SDF_READABLE | SDF_CMD_READ;

		s->subdev_flags = SDF_CMD_READ | SDF_DIFF;

		s->n_chan = board->n_aichan;

		s->subdev_flags |= SDF_DIFF;

		s->maxdata = board->ai_maxdata;

		s->len_chanlist = board->ai_chanlist;

		s->range_table = board->ai_range_type;

		s->cancel = pcl816_ai_cancel;

		s->insn_read = pcl816_ai_insn_read;

		if (dev->irq) {

			dev->read_subdev = s;

			s->subdev_flags |= SDF_CMD_READ;

			s->len_chanlist = board->ai_chanlist;

			s->do_cmdtest = pcl816_ai_cmdtest;

			s->do_cmd = pcl816_ai_cmd;

			s->poll = pcl816_ai_poll;

		s->insn_read = pcl816_ai_insn_read;

			s->cancel = pcl816_ai_cancel;

		}

	} else {

		s->type = COMEDI_SUBD_UNUSED;

	}