Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0a6bf658 authored by Ira W. Snyder's avatar Ira W. Snyder Committed by Guenter Roeck
Browse files

hwmon: (ltc4215) make sysfs file match the alarm cause 



The ltc4215 driver used the chip's "power good" status bit to provide
the power1_alarm file. This is wrong: the chip is really reporting the
status of one of the monitored voltages.

Change the sysfs file from power1_alarm to in2_min_alarm instead. This
matches the voltage that the chip is raising an alarm for.

Signed-off-by: default avatarIra W. Snyder <iws@ovro.caltech.edu>
Signed-off-by: default avatarGuenter Roeck <guenter.roeck@ericsson.com>
parent 6313e3c2

drivers/hwmon/ltc4215.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -205,7 +205,6 @@ LTC4215_ALARM(curr1_max_alarm, (1 << 2), LTC4215_STATUS); 




/* Power (virtual) */

/* Power (virtual) */

LTC4215_POWER(power1_input);

LTC4215_POWER(power1_input);

LTC4215_ALARM(power1_alarm,	(1 << 3),	LTC4215_STATUS);





/* Input Voltage */

/* Input Voltage */

LTC4215_VOLTAGE(in1_input,			LTC4215_ADIN);

LTC4215_VOLTAGE(in1_input,			LTC4215_ADIN);
@@ -214,6 +213,7 @@ LTC4215_ALARM(in1_min_alarm, (1 << 1), LTC4215_STATUS); 




/* Output Voltage */

/* Output Voltage */

LTC4215_VOLTAGE(in2_input,			LTC4215_SOURCE);

LTC4215_VOLTAGE(in2_input,			LTC4215_SOURCE);

LTC4215_ALARM(in2_min_alarm,	(1 << 3),	LTC4215_STATUS);





/* Finally, construct an array of pointers to members of the above objects,

/* Finally, construct an array of pointers to members of the above objects,

 * as required for sysfs_create_group()

 * as required for sysfs_create_group()
@@ -223,13 +223,13 @@ static struct attribute *ltc4215_attributes[] = { 
	&sensor_dev_attr_curr1_max_alarm.dev_attr.attr,

	&sensor_dev_attr_curr1_max_alarm.dev_attr.attr,





	&sensor_dev_attr_power1_input.dev_attr.attr,

	&sensor_dev_attr_power1_input.dev_attr.attr,

	&sensor_dev_attr_power1_alarm.dev_attr.attr,





	&sensor_dev_attr_in1_input.dev_attr.attr,

	&sensor_dev_attr_in1_input.dev_attr.attr,

	&sensor_dev_attr_in1_max_alarm.dev_attr.attr,

	&sensor_dev_attr_in1_max_alarm.dev_attr.attr,

	&sensor_dev_attr_in1_min_alarm.dev_attr.attr,

	&sensor_dev_attr_in1_min_alarm.dev_attr.attr,





	&sensor_dev_attr_in2_input.dev_attr.attr,

	&sensor_dev_attr_in2_input.dev_attr.attr,

	&sensor_dev_attr_in2_min_alarm.dev_attr.attr,





	NULL,

	NULL,

};

};