Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 08e74be1 authored by Parav Pandit's avatar Parav Pandit Committed by Jason Gunthorpe
Browse files

RDMA/uverbs: Fix error cleanup path of ib_uverbs_add_one() 



If ib_uverbs_create_uapi() fails, dev_num should be freed from the bitmap.

Fixes: 7d96c9b1 ("IB/uverbs: Have the core code create the uverbs_root_spec")
Signed-off-by: default avatarParav Pandit <parav@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent f40f299b

drivers/infiniband/core/uverbs_main.c

+2 −3
Original line number Diff line number Diff line
@@ -1050,7 +1050,7 @@ static void ib_uverbs_add_one(struct ib_device *device) 
	uverbs_dev->num_comp_vectors = device->num_comp_vectors;



	if (ib_uverbs_create_uapi(device, uverbs_dev))

		goto err;

		goto err_uapi;



	cdev_init(&uverbs_dev->cdev, NULL);

	uverbs_dev->cdev.owner = THIS_MODULE;
@@ -1077,11 +1077,10 @@ static void ib_uverbs_add_one(struct ib_device *device) 


err_class:

	device_destroy(uverbs_class, uverbs_dev->cdev.dev);



err_cdev:

	cdev_del(&uverbs_dev->cdev);

err_uapi:

	clear_bit(devnum, dev_map);



err:

	if (atomic_dec_and_test(&uverbs_dev->refcount))

		ib_uverbs_comp_dev(uverbs_dev);