Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 05c88bab authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4: Fix a typo in nfs_inode_reclaim_delegation



We were intending to put the previous instance of delegation->cred
before setting a new one.

Thanks to David Howells for spotting this.

Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent f43bf0be
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -109,6 +109,7 @@ static void nfs_delegation_claim_opens(struct inode *inode, const nfs4_stateid *
void nfs_inode_reclaim_delegation(struct inode *inode, struct rpc_cred *cred, struct nfs_openres *res)
{
	struct nfs_delegation *delegation = NFS_I(inode)->delegation;
	struct rpc_cred *oldcred;

	if (delegation == NULL)
		return;
@@ -116,11 +117,12 @@ void nfs_inode_reclaim_delegation(struct inode *inode, struct rpc_cred *cred, st
			sizeof(delegation->stateid.data));
	delegation->type = res->delegation_type;
	delegation->maxsize = res->maxsize;
	put_rpccred(cred);
	oldcred = delegation->cred;
	delegation->cred = get_rpccred(cred);
	delegation->flags &= ~NFS_DELEGATION_NEED_RECLAIM;
	NFS_I(inode)->delegation_state = delegation->type;
	smp_wmb();
	put_rpccred(oldcred);
}

/*