Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0438ee70 authored by Jiri Kosina's avatar Jiri Kosina
Browse files

HID: cp2112: fix incorrect error propagation in cp2112_xfer() 



Both cp2112_read_req() and cp2112_write_req() are returning negative
value in cases of error, but cp2112_xfer() is storing the return
value into unsigned size_t-typed 'count'.

Fix this by making 'count' signed type.

Reported-by: default avatar <fengguang.wu@intel.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent a47dc4d8

drivers/hid/hid-cp2112.c

+1 −1
Original line number Diff line number Diff line
@@ -428,7 +428,7 @@ static int cp2112_xfer(struct i2c_adapter *adap, u16 addr, 
	struct hid_device *hdev = dev->hdev;

	u8 buf[64];

	__be16 word;

	size_t count;

	ssize_t count;

	size_t read_length = 0;

	unsigned int retries;

	int ret;