Commit ffecad95 authored Oct 17, 2007 by Satyam Sharma Committed by Thomas Gleixner Oct 17, 2007

i386: fix argument signedness warnings



These build warnings:

In file included from include/asm/thread_info.h:16,
from include/linux/thread_info.h:21,
from include/linux/preempt.h:9,
from include/linux/spinlock.h:49,
from include/linux/vmalloc.h:4,
from arch/i386/boot/compressed/misc.c:14:
include/asm/processor.h: In function cpuid_count
include/asm/processor.h:615: warning: pointer targets in passing argument 1 of native_cpuid differ in signedness
include/asm/processor.h:615: warning: pointer targets in passing argument 2 of native_cpuid differ in signedness
include/asm/processor.h:615: warning: pointer targets in passing argument 3 of native_cpuid differ in signedness
include/asm/processor.h:615: warning: pointer targets in passing argument 4 of native_cpuid differ in signedness

come because the arguments have been specified as pointers to (signed) int
types, not unsigned. So let's specify those as unsigned. Do some codingstyle
here and there while at it.

[ tglx: arch/x86 adaptation ]

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 7e02cb94

include/asm-x86/processor_32.h

+6 −3

Original line number	Original line	Diff line number	Diff line
	@@ -595,7 +595,9 @@ static inline void load_esp0(struct tss_struct tss, struct thread_struct threa
	* clear %ecx since some cpus (Cyrix MII) do not set or clear %ecx		* clear %ecx since some cpus (Cyrix MII) do not set or clear %ecx
	* resulting in stale register contents being returned.		* resulting in stale register contents being returned.
	*/		*/
	static inline void cpuid(unsigned int op, unsigned int eax, unsigned int ebx, unsigned int ecx, unsigned int edx)		static inline void cpuid(unsigned int op,
			unsigned int eax, unsigned int ebx,
			unsigned int ecx, unsigned int edx)
	{		{
	*eax = op;		*eax = op;
	*ecx = 0;		*ecx = 0;
	@@ -603,8 +605,9 @@ static inline void cpuid(unsigned int op, unsigned int eax, unsigned int ebx,
	}		}

	/* Some CPUID calls want 'count' to be placed in ecx */		/* Some CPUID calls want 'count' to be placed in ecx */
	static inline void cpuid_count(int op, int count, int eax, int ebx, int *ecx,		static inline void cpuid_count(unsigned int op, int count,
	int *edx)		unsigned int eax, unsigned int ebx,
			unsigned int ecx, unsigned int edx)
	{		{
	*eax = op;		*eax = op;
	*ecx = count;		*ecx = count;