Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ff66e3ce authored by Andrew Morton's avatar Andrew Morton Committed by Greg Kroah-Hartman
Browse files

drivers/usb/core/devio.c: suppress warning with 64k PAGE_SIZE 



drivers/usb/core/devio.c: In function 'proc_control':
drivers/usb/core/devio.c:657: warning: comparison is always false due to limited range of data type

Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Pete Zaitcev <zaitcev@redhat.com>
Cc: Oliver Neukum <oliver@neukum.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 8873aaa6

drivers/usb/core/devio.c

+3 −1
Original line number Diff line number Diff line
@@ -647,6 +647,7 @@ static int proc_control(struct dev_state *ps, void __user *arg) 
	struct usbdevfs_ctrltransfer ctrl;

	unsigned int tmo;

	unsigned char *tbuf;

	unsigned wLength;

	int i, j, ret;



	if (copy_from_user(&ctrl, arg, sizeof(ctrl)))
@@ -654,7 +655,8 @@ static int proc_control(struct dev_state *ps, void __user *arg) 
	ret = check_ctrlrecip(ps, ctrl.bRequestType, ctrl.wIndex);

	if (ret)

		return ret;

	if (ctrl.wLength > PAGE_SIZE)

	wLength = ctrl.wLength;		/* To suppress 64k PAGE_SIZE warning */

	if (wLength > PAGE_SIZE)

		return -EINVAL;

	tbuf = (unsigned char *)__get_free_page(GFP_KERNEL);

	if (!tbuf)